Feat: Section override v2 ProductDetailsSettings
#2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
eduardoformiga
changed the title
ProductDetailsSettings
1 task
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
eduardoformiga
force-pushed
the
feat/SFS-786-override-product-details-settings-2
branch
from
0bfe3da
to
99e3436
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
codesandbox check is flaky, but the version was generated successfully if you open the details link. |
eduardoformiga
requested review from
hellofanny and
lariciamota
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
lucasfp13
approved these changes
Jun 6, 2024
eduardoformiga
deleted the
feat/SFS-786-override-product-details-settings-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR aims to enable the override of the
ProductDetailsSettingscomponent fromProductDetailssection. This override has priority over the internal component's overrides (BuyButton,ProductPrice,QuantitySelector).Feat: adds product details settings to experimental list vtexdocs/dev-portal-content#1192
Starters Deploy Preview
ProductDetailsSettingsoverride vtex-sites/starter.store#452