Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for namespace handlers #3

Merged
merged 3 commits into from
Aug 18, 2016
Merged

Conversation

rdumont
Copy link
Contributor

@rdumont rdumont commented Aug 17, 2016

What I wanted to do was to have a handler (along with description, args etc.) directly under a namespace. These are the two issues that were found and fixed:

  1. In the namespace handler there was always one arg missing from the left. Now all args are being passed appropriately.
  2. The help function threw an exception when trying to deal with a namespace that is also a command. Now it doesn't, and the command is being documented as expected.

@drawveloper
Copy link
Contributor

That looks great :) Thanks!

LGTM

@rdumont rdumont merged commit dd98177 into master Aug 18, 2016
@rdumont rdumont deleted the bug/namespace-handlers branch August 18, 2016 09:43
@drawveloper
Copy link
Contributor

Ah, can you also update the README? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants