Typescript types definition location

[emersonlaurentino]

What is to be discussed?
Typescript types definition location.

Describe the solution you'd like
Create a declaration file when they are common between files, otherwise leave inside the file itself. But never create global types.

Additional context
There are developers who declare types within the file itself and export to other files, there are others who like global types and others who define them in a declaration file.

[jgfidelis]

I prefer to use declaration files as well if types are shared across multiple files

[kaisermann]

It's always better to have separate declaration files. However, how those typings are going to be used defines if it's better to put them in a .d.ts or .ts file.

My rule of thumb is: is the typings supposed to be consumed by other apps/libs? .ts and import them where needed. If you only need them to type your project, .d.ts and use them globally.

[emersonlaurentino]

@kaisermann honestly i don't like global types. @salesfelipe has an opinion on the use of enum when in global types...

[kaisermann]

@emersonlaurentino probably because he needed the enum elsewhere, so .ts with explicit imports would be the way to go. I don't think we need to write in stone that you SHOULD NEVER USE GLOBAL TYPINGS, but one must be aware of the caveats of the approach.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is a discussion thread, the most voted option will be final. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is a discussion thread, the most voted option will be final. Thank you for your contributions.