Add workspace querystring #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klzns
suggested changes
Dec 11, 2017
src/checkout.coffee
Outdated
| addWorkspaceQueryString = (url) -> | ||
| workspace = urlParam('workspace') | ||
| if workspace | ||
| if window.location.search.length > 0 |
There was a problem hiding this comment.
Não entendi pra que serve esse if, vc nao deveria ver se na variável url tem parametros de queryString?
klzns
approved these changes
Dec 11, 2017
klzns
suggested changes
Dec 12, 2017
src/checkout.coffee
Outdated
|
|
||
| getGiftCardProviders: () => | ||
| @ajax | ||
| url: addWorkspaceQueryString(window.location.origin + '/api/checkout/pub/gift-cards/providers') |
There was a problem hiding this comment.
Criar função privada para pegar a URL como é feito nos outros casos.
klzns
suggested changes
Dec 13, 2017
src/checkout.coffee
Outdated
| @ajax | ||
| type: 'POST', | ||
| contentType: 'application/json; charset=UTF-8', | ||
| url: addWorkspaceQueryString('/api/checkout/pub/orderForms/simulation'), |
src/checkout.coffee
Outdated
| @@ -417,7 +429,7 @@ class Checkout | |||
| clearMessages: (expectedOrderFormSections = @_allOrderFormSections) => | |||
| clearMessagesRequest = { expectedOrderFormSections: expectedOrderFormSections } | |||
| @ajax | |||
| url: @_getOrderFormURL() + '/messages/clear' | |||
| url: addWorkspaceQueryString(@_getOrderFormURL() + '/messages/clear') | |||
src/checkout.coffee
Outdated
| @@ -408,7 +420,7 @@ class Checkout | |||
| # Sends a request to retrieve the orders for a specific orderGroupId. | |||
| getOrders: (orderGroupId) => | |||
| @ajax | |||
| url: @_getOrdersURL(orderGroupId) | |||
| url: addWorkspaceQueryString(@_getOrdersURL(orderGroupId) + workspaceQueryString) | |||
klzns
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
To add workspace querystring on all checkout requests