Add getOrderFormUrl to getOrderForm to support queryString first #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analuizamtg
approved these changes
Mar 12, 2018
leticiawanderley
approved these changes
Mar 12, 2018
omninando
force-pushed
the
feature/order-form-id-query-string
branch
4 times, most recently
from
8ae6b56
to
41f0641
Compare
klzns
suggested changes
Apr 13, 2018
package.json
Outdated
| "mocha": "^1.21.5" | ||
| }, | ||
| "scripts": { | ||
| "test": "./node_modules/karma/bin/karma start --single-run", | ||
| "test-watch": "./node_modules/karma/bin/karma start" | ||
| "test-watch": "./node_modules/karma/bin/karma karma start" |
src/checkout.coffee
Outdated
| if id is '' | ||
| throw new Error "This method requires an OrderForm. Use getOrderForm beforehand." | ||
| "#{@_getBaseOrderFormURL()}/#{id}" | ||
| if id then "#{@_getBaseOrderFormURL()}/#{id}" else @_getBaseOrderFormURL() |
There was a problem hiding this comment.
Pq essa alteração? Não faz mt sentido, isso deve dar erro.
There was a problem hiding this comment.
eu vou pegar o id e se eu não tiver o id eu peço um id chamando a api com @_getBaseOrderFormURL()
There was a problem hiding this comment.
Eu vou pegar o id e se eu não tiver o id eu peço um id chamando a api com @_getBaseOrderFormURL().
Como pode dar erro?
There was a problem hiding this comment.
@_getBaseOrderFormURL retorna uma string e nao uma chamada a API
omninando
force-pushed
the
feature/order-form-id-query-string
branch
from
41f0641
to
7db7366
Compare
klzns
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.