Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue where acknowledgement content was scrolled up slightly #43

Merged
merged 1 commit into from
Nov 14, 2015

Conversation

levigroker
Copy link
Contributor

While the default value of a UITextView's contentOffset should be CGPointZero I was seeing (iOS 9) the content scrolled slightly up, and under the navigation bar. Resetting the contentOffset after textContainerInset corrects this issue.

vtourraine added a commit that referenced this pull request Nov 14, 2015
Fixing issue where acknowledgement content was scrolled up slightly
@vtourraine vtourraine merged commit da2e149 into vtourraine:master Nov 14, 2015
@vtourraine
Copy link
Owner

Thanks for the PR, Levi, and I apologize that it look me so long to merge it in (especially for a one-line fix). Nice catch. 👍

@levigroker levigroker deleted the content_offset_fix branch November 16, 2015 17:53
@levigroker
Copy link
Contributor Author

@vtourraine No worries. Thanks for taking the pull. :)

@levigroker
Copy link
Contributor Author

@vtourraine Would you mind adding this to a new Cocoapod version please?

@vtourraine
Copy link
Owner

I will, in general I’m simply waiting for a couple of days after any change on master before pushing it as a new version, in case we missed something.

In the meantime (and someone might find it useful beyond this case here), you can always use pod 'VTAcknowledgementsViewController', :head in your Podfile to get the latest source.

@vtourraine
Copy link
Owner

There you go: version 0.16 (https://cocoapods.org/pods/VTAcknowledgementsViewController).

@levigroker
Copy link
Contributor Author

Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants