Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid uncaught error when user closes the WalletConnect QR modal. #69

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

re2005
Copy link
Collaborator

@re2005 re2005 commented Aug 3, 2022

Currently when you open the connect modal.

If you select WalletConnect and on the QR code screen, close the window. you will have an uncaught error in your application.

WalletConnect.error.mov

@netlify
Copy link

netlify bot commented Aug 3, 2022

Deploy Preview for vue-dapp-docs ready!

Name Link
🔨 Latest commit 0c9c2e5
🔍 Latest deploy log https://app.netlify.com/sites/vue-dapp-docs/deploys/62eabc060e6c31000979e302
😎 Deploy Preview https://deploy-preview-69--vue-dapp-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 3, 2022

Deploy Preview for vue-dapp ready!

Name Link
🔨 Latest commit 0c9c2e5
🔍 Latest deploy log https://app.netlify.com/sites/vue-dapp/deploys/62eabc06a7f72d00081f81bd
😎 Deploy Preview https://deploy-preview-69--vue-dapp.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@re2005
Copy link
Collaborator Author

re2005 commented Aug 4, 2022

@chnejohnson can you please take a look into this PR.

@johnson86tw johnson86tw merged commit aea3fe3 into vu3th:main Aug 4, 2022
@johnson86tw
Copy link
Member

LGTM, Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants