Skip to content
This repository has been archived by the owner on Jun 22, 2024. It is now read-only.

fix(compiler): when useStorage returns a Uint8Array, decode it to text (fixes #33) #34

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

L422Y
Copy link
Contributor

@L422Y L422Y commented Mar 1, 2024

Addresses issue (#33) where when useStorage.getItem returns a Uint8Array instead of a string, which breaks server-side template compilation/rendering

@Flowko
Copy link
Member

Flowko commented Mar 1, 2024

could you please run pnpm lint:fix on the branch

@L422Y
Copy link
Contributor Author

L422Y commented Mar 1, 2024

Done!

@Flowko
Copy link
Member

Flowko commented Mar 1, 2024

will ignore the releasing to edge, but somehow that error still presisits, have you checked https://stackblitz.com/~/github.com/batihandev/ven-reproduction

@Flowko
Copy link
Member

Flowko commented Mar 1, 2024

will merge this and test on a fresh stackblitz instance

@Flowko Flowko merged commit acf7373 into vue-email:main Mar 1, 2024
1 check failed
@L422Y
Copy link
Contributor Author

L422Y commented Mar 1, 2024

will ignore the releasing to edge, but somehow that error still presisits, have you checked https://stackblitz.com/~/github.com/batihandev/ven-reproduction

Didn't check there, but it resolved the exact same issue in my own application both locally and in staging/prod when using a built Nuxt application.

@Flowko
Copy link
Member

Flowko commented Mar 1, 2024

ok thanks, propably stackblitz has some weird configurations

@L422Y L422Y deleted the patch-1 branch March 13, 2024 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants