Skip to content

Update dev example after #113 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 13, 2017
Merged

Update dev example after #113 #114

merged 3 commits into from
Feb 13, 2017

Conversation

icebob
Copy link
Member

@icebob icebob commented Feb 13, 2017

No description provided.

@icebob icebob changed the title Merged #112 Update dev example after #113 Feb 13, 2017
@icebob icebob merged commit 52de300 into master Feb 13, 2017
@icebob icebob deleted the pr/113 branch February 13, 2017 12:53
@lionel-bijaoui
Copy link
Member

I don't agree with the changes for moment.js.
By using the already minified version of moment, we reduce the chance of the minifier of vfg to do it's best job. It has to minify normal code with minified code, and I don't claim to know how it work, but I think that's not the best.
Also, we loose the sourcemap of moment.js.

This was referenced Feb 13, 2017
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icebob @lionel-bijaoui