Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "clean" CSS class for untouched fields #495

Merged

Conversation

lionel-bijaoui
Copy link
Member

@lionel-bijaoui lionel-bijaoui commented Sep 26, 2018

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature
  • What is the new behavior (if this is a feature change)?
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Field don't have a valid class at start. They start with clean and once they are edited or validated they loose it. Then, they either have valid or error class.
  • Other information:
    • Add "clean" when the value is not manually changed or validated
    • If changed or validated, loose the clean state and is either 'valid" or "error"
    • Class name can be customised with "validationCleanClass"
    • use internal "vfgTouched" value to track state of field

- Add "clean" when the value is not manually changed or validated
- If changed or validated, loose the clean state and is either 'valid" or "error"
- Class name can be customised with "validationCleanClass"
- use internal "vfgTouched" value to track state of field
@coveralls
Copy link

coveralls commented Sep 26, 2018

Coverage Status

Coverage increased (+0.2%) to 87.689% when pulling 4f6b05e on lionel-bijaoui:lb_clean_validation_state into b02d866 on vue-generators:v3.

@lionel-bijaoui lionel-bijaoui merged commit 19b42e3 into vue-generators:v3 Sep 28, 2018
@lionel-bijaoui lionel-bijaoui deleted the lb_clean_validation_state branch September 28, 2018 08:55
@lionel-bijaoui lionel-bijaoui added this to Done in v3.0 Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
v3.0
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants