Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Edge Cases #95

Merged
merged 4 commits into from
Mar 26, 2019
Merged

Conversation

gustialfian
Copy link

Mas @mazipan bisa tolong direview. Karena halamannya yang cukup panjang dan ada beberapa konsep yang baru kenal pada saat menerjemahkan jadinya mungkin ada beberapa paragraf yang masih belum jelas.

@nusendra nusendra added the in-review PR already created, waiting for approval label Mar 22, 2019
@nusendra nusendra self-assigned this Mar 22, 2019
Copy link
Member

@mandaputtra mandaputtra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustialfian hello mas, berikut review yang perlu check

src/v2/guide/components-edge-cases.md Outdated Show resolved Hide resolved
src/v2/guide/components-edge-cases.md Outdated Show resolved Hide resolved
src/v2/guide/components-edge-cases.md Outdated Show resolved Hide resolved
src/v2/guide/components-edge-cases.md Outdated Show resolved Hide resolved
src/v2/guide/components-edge-cases.md Outdated Show resolved Hide resolved
src/v2/guide/components-edge-cases.md Outdated Show resolved Hide resolved
src/v2/guide/components-edge-cases.md Show resolved Hide resolved
src/v2/guide/components-edge-cases.md Outdated Show resolved Hide resolved
src/v2/guide/components-edge-cases.md Outdated Show resolved Hide resolved
src/v2/guide/components-edge-cases.md Outdated Show resolved Hide resolved
@gustialfian
Copy link
Author

terimakasih reviewnya mas @mandaputtra selain dari pertanyaanya yang diatas saya perbaiki.

@gustialfian
Copy link
Author

ok mas @mandaputtra, revisinya sudah saya commit.

@mandaputtra
Copy link
Member

@gustialfian Thanks a lot mas saya baca kembali yak nanti. lalu saya merge pull request mas. 😃 ✋

den => dan
@mandaputtra
Copy link
Member

@nusendra mas untuk review dari saya sepertinya sudah cukup bila rasa mas ada tambahan mungkin bisa ditambahkan. kalau tidak mungkin bisa di merge.

@gustialfian
Copy link
Author

Klo gitu merge aj mas.

@mandaputtra mandaputtra merged commit 0b955c3 into vuejs-id:master Mar 26, 2019
@mandaputtra mandaputtra removed the in-review PR already created, waiting for approval label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants