Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated file name to manifest.webmanifest #148

Closed
wants to merge 1 commit into from
Closed

Updated file name to manifest.webmanifest #148

wants to merge 1 commit into from

Conversation

benmccallum
Copy link

Based on latest recommendation/spec.

This will require some servers to have the extension > mimeType mapping added. For IIS I have a web.config with the addition force-ably added to my dist folder. But I feel like adding this would be outside the scope of this repo.

@jeffposnick
Copy link
Collaborator

Thanks for the contribution! I don't think it makes sense to move ahead with this, though. See a similar discussion in the create-react-app repo for background on why sticking with manifest.json makes sense: facebook/create-react-app#3592 (comment)

@jeffposnick jeffposnick closed this Jan 8, 2018
@benmccallum
Copy link
Author

No worries. If the spec doesn't technically require it then fair enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants