feat: preprocess scss/sass styles with node-sass #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yyx990803 Please review this. Other style dialect preprocessors would be built in similar fashion. |
yyx990803
requested changes
Apr 4, 2018
lib/styleProcessors/index.ts
Outdated
| map: any | null, | ||
| options: any | ||
| ): StylePreprocessorResults { | ||
| if (!nodeSass) nodeSass = require("node-sass"); |
There was a problem hiding this comment.
require calls are cached anyway so no need to cache it ourselves here
lib/styleProcessors/index.ts
Outdated
| } | ||
|
|
||
| export interface StylePreprocessorResults { | ||
| source: string; |
There was a problem hiding this comment.
results should use code instead of source
lib/styleProcessors/index.ts
Outdated
|
|
||
| export interface StylePreprocessorResults { | ||
| source: string; | ||
| map?: any; |
There was a problem hiding this comment.
There are a bunch of semicolons, make sure to stay consistent with the style of the rest of the codebase
There was a problem hiding this comment.
Do we have a style lint config for ts? These semicolons were added by VS code format.
|
Btw I think we should start writing tests before working on other features. |
- Remove semi-colons - Use `code` instead of `source` in preprocessor output
yyx990803
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.