fix: add emits options to defineComponent(fix #553) #554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://v3.vuejs.org/guide/component-custom-events.html#defining-custom-events
https://eslint.vuejs.org/rules/require-explicit-emits.html
Though it has no effects on Vue2, but we can still add
emits: string[] | Record<string, null | ((emitData: any) => boolean) >
indefineComponent
for better documenting and to avoid eslint-plugin-vue@V7 throwing warnings.Also, we have to warn people in readme that this has no effects for validating the emit event and just for smoothing the miragation.
Adding
emits
options will broke ThisType in defineComponent now.while eslint will throw warnings if using
vue/require-explicit-emits