Skip to content

fix(reactivity): ensure extended method arguments are not lost #11574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2024
Merged

fix(reactivity): ensure extended method arguments are not lost #11574

merged 2 commits into from
Aug 10, 2024

Conversation

edison1105
Copy link
Member

close #11573

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 98.6 kB 37.4 kB 33.7 kB
vue.global.prod.js 156 kB 57.2 kB 50.8 kB

Usages

Name Size Gzip Brotli
createApp 54.1 kB 21 kB 19.1 kB
createSSRApp 58 kB 22.6 kB 20.6 kB
defineCustomElement 58.7 kB 22.5 kB 20.5 kB
overall 67.7 kB 26 kB 23.7 kB

@edison1105 edison1105 linked an issue Aug 9, 2024 that may be closed by this pull request
parameter missing in extended array find method #11573
Closed
@edison1105 edison1105 added scope: reactivity version: minor ready for review This PR requires more reviews 🐞 bug Something isn't working labels Aug 9, 2024
@yyx990803 yyx990803 force-pushed the minor branch 2 times, most recently from 70e7329 to cffe866 Compare August 9, 2024 13:08
Disservin
Disservin reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@Disservin Disservin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to rebase this to the current state of the minor branch this pr still includes some ci changes

@yyx990803 yyx990803 merged commit 4085def into vuejs:minor Aug 10, 2024
@linzhe141 linzhe141 mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Disservin Disservin Disservin left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
🐞 bug Something isn't working ready for review This PR requires more reviews scope: reactivity version: minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parameter missing in extended array find method
3 participants
@edison1105 @Disservin @yyx990803