Skip to content

Conversation

jh-leong
Copy link
Member

@jh-leong jh-leong commented Sep 3, 2024

close #11792

Copy link

github-actions bot commented Sep 3, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+7 B) 37.7 kB (+5 B) 33.9 kB (+5 B)
vue.global.prod.js 159 kB (+7 B) 57.5 kB (+3 B) 51.1 kB (-39 B)

Usages

Name Size Gzip Brotli
createApp 55.1 kB (+7 B) 21.2 kB (+3 B) 19.3 kB (-1 B)
createSSRApp 59.1 kB (+7 B) 22.9 kB (+3 B) 20.9 kB (+44 B)
defineCustomElement 59.8 kB (+7 B) 22.7 kB (+3 B) 20.7 kB (+5 B)
overall 68.8 kB (+7 B) 26.3 kB (+2 B) 23.9 kB (-9 B)

Copy link

pkg-pr-new bot commented Sep 3, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11794

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11794

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11794

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11794

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11794

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11794

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11794

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11794

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11794

vue

pnpm add https://pkg.pr.new/vue@11794

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11794

commit: c747cdb

@jh-leong jh-leong marked this pull request as draft September 3, 2024 15:30
@jh-leong jh-leong marked this pull request as ready for review September 3, 2024 15:34
@jh-leong jh-leong added 🐞 bug Something isn't working ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Sep 3, 2024
Copy link

@shaunakv1 shaunakv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fixes the original issue

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: reactivity regression and removed regression labels Sep 4, 2024
@yyx990803 yyx990803 merged commit 475977a into vuejs:main Sep 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working ready to merge The PR is ready to be merged. scope: reactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to 3.5 breaks existing code when input value binding is an object
4 participants