-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UMD support #7323
Comments
I have trouble understand what supposed problem a UMD build would solve. I also don'T see the connection with the linked issues.
I I had to guess, your problem might be that you include the ESM build as a plain, non-module |
If you hav an actual bug to report, please do so in an issue with a bug report with a runnable reproduction |
the way to solve the issue => close.
did UMD format bad as im not use it in a commonjs environment and i tested react、angular it's all works fine,but vue have problem and rise issue -> close twice. so as a system designer in opensource, you think “we need teach our user how to use our product?”. and following the same pattern product same page is the goal? or UMD is a big work of change? i think neither. arrogant is. |
You did not raise an issue, you opened a feature request - for a feature that i don't see necessary. If you rather think you have a bug, you should follow the issue guidelines and open an issue with a runnable reproduction. I still don't really have any idea what the problem is that you are trying to describe. a runnable reproduction could clear that up. |
in this issue i talk about 2 issue one is vue umd support,one is vite bundle of pollution global (and this have a link). if the issue would be fix,just fix.in this case,i can switch to react and i can make a work around . i'm not start project now,because the bundle formate problem,for me not have nessary to fix it .so let them exist,it's NOT my project,i think i'm a contributor of this,im not begger.current was tired of write issue about vue and vite vitejs/vite#10822 (comment) other guys jump in and understand what im point,but vite need a reproduction to reproduce. and i was make a work around. thats fine, if i use edit this comment estimated time it have already work around. |
Bug reports require runnable reproductions. even us core contributors do follow that rule when we open issues ourselves. We ask the same from other people reporting problems. Runnable reproductions are required for us to be able to understand a problem clearly. Now a few points, trying to explain my problems of understanding you.
Now we have another issue open, again with zero code to check out, and after all of these Issues I'm sorry to say I still don't understand the problem. Code would help. You don't want to provide code. So we will keep this issue closed.
Everyone is required to provide runnable reproductions in bug reports, even core contributors (i.e. #7319). Us asking for a runnable reproduction of a problem is not us making you beg. It's us asking for minimal standards in order to be able to understand the problem. |
ok ok,we need a runnable reproductions to debug it,screen shot or logs not enough,leave it and have a good day. |
Yes. Not enough. Good day to you to. |
vite 或者是任何现代打包工具打包 Vue 3 都会默认引用 esm 格式,不存在全局变量污染。而 global 格式顾名思义就是暴露全局变量用的。 你的问题到底是什么,你并没有解释清楚。你自己觉得 umd 是唯一解决你问题的答案,我们觉得未必。你是不得不用一个不能处理 esm 的打包工具呢,还是错误的引用了 global 包呢,还是什么其他情况,你不提供重现,我们怎么可能知道? 另外,一个建议:调整下心态,加强一下沟通能力,好好说话。开源维护者不欠你任何东西,你如果不能心平气和的沟通,那我们也不会有兴趣解决你的问题,最终吃亏的是你自己。 |
算了我删了,不想事多,都解决了没必要浪费彼此的时间和精力,这几个issue从时间线上已经足够说明很多 |
早上一来看到这么多人点赞,细细一看,原来是家人们,那我把之前想说的也发上来。 ========
|
这个大概是最大的分歧点了,你觉得你已经讲清楚了,但是读的人可能并没能看懂……你提到的其他 issue 结合起来看也没有帮助我们准确理解到问题所在。
LinusBorg 回复的第一句就很能说明问题。
通篇读下来没有感受到“把自己当 contributor”,而是包含了很多反问和嘲讽性的语言。上面说的 “调整下心态,加强一下沟通能力,好好说话” 其实就是希望你不要用反问和嘲讽来讨论问题,仅此而已。你上面的回复明显是把这句建议本身也当作了嘲讽,然后开始用更加激进的语言回应了。 然而,你回复越冲,越不利于讨论和理解问题,恶性循环呀。不要带上主观恶意,冷静一下,好好讨论问题。 |
vitejs/vite#10822 的问题是你没搞明白 Vite 的输出产物格式。vite build 的默认输出是 esm,需要用 另一方面,这跟 Vue 是否提供 UMD 根本是不相干的问题,Vue 的 global build 就是专门用于非 ESM 的普通 你想要 umd support,你得解释清楚为什么一定要有 umd support。#7206 这里模糊的提到你的使用场景,但是信息完全不够。可能是你用的打包工具很特殊,不支持 esm,也可能是你在应该用 import 的场景下用了 require(),也可能是因为你还在用你在 vite 那个 issue 里用的错误用法,那么我们需要知道到底是什么情况,所以才会要求给重现。 直白点说,你对整个问题的理解从一开始就是错的,还把不相干的问题混到了一起,表达能力欠缺,态度上又咄咄逼人,我们能这样跟你说话已经很给面子了。 本 issue 下 Linus 的第一个回复很合理,完全没有任何问题。而你自己看一下你的第一个回复,各种反问,暗讽,说我们傲慢,如果你觉得你的沟通没有问题,我们可以 block 你,因为我们不欢迎你这样的用户。 |
之前就说过了,这是2个问题,既然是两个问题,所以就是不相干的问题,还要下面再给解释一番,然后说表达能力欠缺?
这不是忽略了最开始的问题给答案么?而且前提是假想出我没有必要用到 umd ,我在上面的问题是:UMD 和直接这么整(用一个空对象把exports的路堵死)有什么区别?这样扩展性就更好了?
不想要了,不想复读——我在上面的问题是:UMD 和直接这么整有什么区别?这样扩展性就更好了?
那么是谁在咄咄逼人,让社区里大家看吧
我这个回复,以及最开始贴出来的issue单,看看什么时候的,我那个时候有没有这么说话,为什么有这么多反问,暗讽,还说你们傲慢,此时此刻难道不是吗? 请把我 block 掉吧 shame |
全篇第一句话就是一句反问,还全然不觉得这种语气有问题。 我们来捋一捋这个 issue 的火药味是怎么来的。 如果我没有理解错,Evan 上面的回复帮你捋清楚了你的实际需求实际上并不需要 Vue 提供 UMD bundle 来解决,而是由于你错误地在 Linus 看了你的 issue,并没有看出 UMD bundle 和你给 Vite 提的 issue 之间有什么关系,而且也给出了判断:你的问题可能是因为用普通 script 引入了 ESM bundle,而不是有真正的 UMD bundle 的需求,进而关闭了 issue。现在看来,这个判断大概率也是对的。 于是你开始嘲讽:解决问题的方式就是关闭 issue,并指责 Linus 傲慢。 后面 Evan 介入,指出你的沟通方式不妥,但你并不接受,认为自己遇到的问题已经“自行解决”了(并没有,而是在错误的用法上打补丁),而且是自己好心给 Vue 提出了解决问题的方案,但并没有重新审视这个问题技术上究竟是什么原因产生的,对于自己的场景提出 UMD 支持是不是实际是一个伪需求。 自始至终你似乎都无视了 Linus 和 Evan 给你分析的,你在 Vite 提的 issue 究竟是什么问题造成的,从而陷入一个对 UMD 支持这个需求的执念。后面 Evan 也说了,提 UMD 的需求解决了什么问题,这是要分析清楚的,并不是不能提。 |
done |
What problem does this feature solve?
no one think umd is better than directly declare a variable in window? for compatibility
vue 2 did this ,it is ok for most integration,is vue3 and vite was maintained by same team ? i think the design and code quality is goes down or some thing (techincal point) i miss understand casue my faulty view.
the vite old design and new issue
vitejs/vite#7948
vitejs/vite#10822
and vue3 dist
What does the proposed API look like?
UMD support pls
The text was updated successfully, but these errors were encountered: