Skip to content

fix(runtime-core): cleanup hoisted vnode when unmount component #9219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

fix(runtime-core): cleanup hoisted vnode when unmount component #9219

wants to merge 8 commits into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Sep 15, 2023 •
edited
Loading

close #5256

NOTE:
disable vue-devtools first, if you want to test on playground

@github-actions
Copy link

github-actions bot commented Sep 15, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.9 kB (+170 B) 34.6 kB (+59 B) 31.1 kB (+31 B)
vue.global.prod.js 148 kB (+170 B) 53.8 kB (+63 B) 48.1 kB (+38 B)

Usages

Name Size Gzip Brotli
createApp 51 kB (+170 B) 19.9 kB (+59 B) 18.2 kB (+67 B)
createSSRApp 54.3 kB (+170 B) 21.3 kB (+51 B) 19.3 kB (+33 B)
defineCustomElement 53.3 kB (+170 B) 20.7 kB (+59 B) 18.8 kB (+56 B)
overall 64.7 kB (+170 B) 25 kB (+56 B) 22.6 kB (+65 B)

skirtles-code
skirtles-code reviewed Oct 4, 2023
View reviewed changes
@wanghanzhen
Copy link

Could this PR be merged? @edison1105

@edison1105
Copy link
Member Author

@wanghanzhen
Due to this PR is not a high priority and we can avoid that problem by hoistStatic: false.
so it may not be merged so soon.

@pengfan2013
Copy link

@wanghanzhen Due to this PR is not a high priority and we can avoid that problem by hoistStatic: false. so it may not be merged so soon.

期望能尽快合进去

@haoqunjiang haoqunjiang added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Mar 29, 2024
@haoqunjiang haoqunjiang self-assigned this Mar 29, 2024
@yyx990803 yyx990803 mentioned this pull request Jun 4, 2024
Merged
@yyx990803
Copy link
Member

Closing in favor of #11067

@yyx990803 yyx990803 closed this Jun 4, 2024
yyx990803 added a commit that referenced this pull request Jun 4, 2024
@yyx990803
fix(compiler-core): change node hoisting to caching per instance (#11067
cd0ea0d 
)

close #5256
close #9219
close #10959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@skirtles-code skirtles-code skirtles-code left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@haoqunjiang haoqunjiang

Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
Issue / PR Management
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak in hoist static
6 participants
@edison1105 @wanghanzhen @pengfan2013 @yyx990803 @skirtles-code @haoqunjiang