fix(ssr): ensure computed only run once during render #9688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
edison1105
changed the title
edison1105
commented
Nov 28, 2023
| @@ -33,7 +33,6 @@ test('computed reactivity during SSR', async () => { | |||
| // In both cases we need to fetch data. | |||
| if (!msg.value) await store.fetchData() | |||
|
|
|||
| expect(msg.value).toBe('hello world') | |||
There was a problem hiding this comment.
For the reasons for deleting this line, see #5300 (comment)
| @@ -144,7 +144,10 @@ function renderComponentSubTree( | |||
| // perf: enable caching of computed getters during render | |||
| // since there cannot be state mutations during render. | |||
| for (const e of instance.scope.effects) { | |||
| if (e.computed) e.computed._cacheable = true | |||
| if (e.computed) { | |||
| e.computed._dirty = true | |||
There was a problem hiding this comment.
Make sure that during ssrRender(), the computed is executed only once and then cached.
yyx990803
pushed a commit
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5300