Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): fix error when using Proxy on reactive arrays #9751

Closed

Conversation

pikax
Copy link
Member

@pikax pikax commented Dec 4, 2023

closes #9742

different implementation #9750

@pikax pikax added 🐞 bug Something isn't working scope: reactivity labels Dec 4, 2023
Copy link

github-actions bot commented Dec 4, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.8 kB (+35 B) 33 kB (+8 B) 29.8 kB (+4 B)
vue.global.prod.js 133 kB (+35 B) 49.8 kB (+9 B) 44.7 kB (+33 B)

Usages

Name Size Gzip Brotli
createApp 48.3 kB (+35 B) 19 kB (+7 B) 17.4 kB (+56 B)
createSSRApp 51.5 kB (+35 B) 20.3 kB (+6 B) 18.5 kB (+9 B)
defineCustomElement 50.6 kB (+35 B) 19.7 kB (+6 B) 18 kB (+12 B)
overall 61.6 kB (+35 B) 23.8 kB (+9 B) 21.7 kB (+44 B)

@starcsb
Copy link

starcsb commented Dec 5, 2023

This implementation method seems incompatible with this test case(if replacing {} with [] in this test case)

@yyx990803 yyx990803 closed this in 6ecbd5c Dec 7, 2023
@yyx990803 yyx990803 deleted the pikax/reactive_arrays_should_be_able_to_be_proxied branch December 7, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working scope: reactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot .push() to a reactive Array that is wrapped in a Proxy
2 participants