fix(reactivity): infinite loops when pushing a variable to a custom proxy of reactive array #9750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9742
When user add a proxy to a reactive array and use motheds of Array such as
push/pop/shift/unshift/includes/indexOf/lastIndexOf/splice
, the result oftoRaw(proxy)
will always return proxy and infinitely triggertoRaw
becausereceiver
isn't the origin proxy(created by vue) oftarget
.So I think when we use the above methods, it should skip the comparsion between
receiver
and the origin proxy(created by vue) oftarget
.