Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(errorHandling): directly return value in callWithErrorHandling #10315

Merged
merged 1 commit into from
Feb 13, 2024
Merged

chore(errorHandling): directly return value in callWithErrorHandling #10315

merged 1 commit into from
Feb 13, 2024

Conversation

OnlyWick
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.4 kB (-9 B) 34.4 kB (-2 B) 31 kB (+5 B)
vue.global.prod.js 148 kB (-9 B) 53.7 kB (-2 B) 47.9 kB (+34 B)

Usages

Name Size Gzip Brotli
createApp 50.5 kB (-9 B) 19.7 kB (-4 B) 18.1 kB (+36 B)
createSSRApp 53.8 kB (-9 B) 21.1 kB (-5 B) 19.2 kB (-55 B)
defineCustomElement 52.8 kB (-9 B) 20.5 kB (-4 B) 18.7 kB (+1 B)
overall 64.2 kB (-9 B) 24.8 kB (-4 B) 22.5 kB (-17 B)

sxzz
sxzz approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, decrased 9 bytes of bundle size

@sxzz sxzz added the ready to merge The PR is ready to be merged. label Feb 11, 2024
@OnlyWick
Copy link
Contributor Author

LGTM, decrased 9 bytes of bundle size

LMAO, Happy New Year!

@yyx990803 yyx990803 merged commit 5f7a0a0 into vuejs:main Feb 13, 2024
11 checks passed
@OnlyWick OnlyWick deleted the directly-return-value-in-callWithErrorHandling branch February 26, 2024 09:06
lynxlangya pushed a commit to lynxlangya/core that referenced this pull request May 30, 2024
@OnlyWick @lynxlangya
chore(errorHandling): directly return value in callWithErrorHandling …
145d067 
…function (vuejs#10315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnlyWick @sxzz @yyx990803