-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explicitly add @vue/reactivity
as dependency of @vue/runtime-dom
#10468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for vue-sfc-playground failed.
|
❌ Deploy Preview for vue-next-template-explorer failed.
|
n0099
changed the title
explicitly add
explicitly add Mar 6, 2024
@vue/reactivity
as dependency and peerDep for @vue/runtime-dom
@vue/reactivity
as dependency of @vue/runtime-dom
n0099
added a commit
to n0099/open-tbm
that referenced
this pull request
Mar 6, 2024
…r named routes `post` and `user` and all their children * fix named route `404` passing the wrong type of props for `<PlaceholderError>` since 25d8550 @ router/index.ts * add workspace settings for vue @ .vscode/settings.json * fix vuejs/core#10468 @ .yarnrc.yml $ yarn eslint --fix src @ fe
3 tasks
Looks like you need to update the lockfile to get CI passing. |
n0099
added a commit
to n0099/open-tbm
that referenced
this pull request
Jun 16, 2024
$ yarn remove @unhead/vue @vitejs/plugin-vue{,-jsx} vite # since they have been hoisted by nuxt $ yarn remove @vue/language-server # since not using `(Web|Php)Storm` $ yarn upgrade-interactive - `packageExtensions` since vuejs/core#10468 appeared in `3.4.28` and `@vue/reactivity` should be hoisted when using `nodeLinker: node-modules` @ .yarnrc.yml @ fe
n0099
added a commit
to n0099/open-tbm
that referenced
this pull request
Jun 16, 2024
$ yarn remove @unhead/vue @vitejs/plugin-vue{,-jsx} vite # since they have been hoisted by nuxt $ yarn remove @vue/language-server # since not using `(Web|Php)Storm` $ yarn upgrade-interactive - `packageExtensions` since vuejs/core#10468 appeared in `3.4.28` and `@vue/reactivity` should be hoisted when using `nodeLinker: node-modules` @ .yarnrc.yml @ fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix phantom/ghost dependency that breaks yarn pnp when overriding
RefUnwrapBailTypes
from@vue/reactivity
core/packages/reactivity/src/ref.ts
Lines 483 to 496 in fef2acb
@vue/runtime-dom
core/packages/runtime-dom/src/index.ts
Lines 29 to 33 in fef2acb