Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hydration): fix css vars hydration mismatch false positive on attr-fallthrough #11190

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

yangxiuxiu1115
Copy link
Contributor

fix #11188

@yyx990803
Copy link
Member

FYI the original implementation only accounted for the direct parent but not possible multiple-level-nested components.

I refactored the logic to a recursive function and also removed the eslint ignores (hydration code paths do run in the browser so optional chaining should be avoided) in ce4b9f2

@yyx990803 yyx990803 merged commit 7ad67ce into vuejs:main Jun 22, 2024
11 checks passed
@yangxiuxiu1115 yangxiuxiu1115 deleted the fix/hydration branch June 22, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydration warning SSR on style using v-bind in SFC together with :style attribute
2 participants