-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(reactivity): unnecessarily func call #11328
Conversation
Can you provide sample code where this happens? Ideally there should be a test case to demonstrate this. |
Size ReportBundles
Usages
|
Hi, Evan. I have added some test cases, and here is the sample code. @yyx990803 |
It's already fixed by https://github.com/vuejs/core/pull/9511/files#diff-2b8c2b531651dd15cee7c2b11e34972f4a4903c114e94e74c0e94bb10f03ed0fR291, but no related test cases were added in #9511, maybe we should keep the test cases in this PR. |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
Sorry for closed, I didn't notice the last part. |
Hello! There are some trouble when we try to find a value form a reactive array. If the arg was a raw value and the target array had not included it, the findValue function will still execute twice. It's unnecessary I think. Maybe we can resolve it by adding a condition.