Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shouldn't not stringify static for top level inside slot, but ca… #1286

Closed
wants to merge 2 commits into from

Conversation

underfin
Copy link
Member

@underfin underfin commented Jun 3, 2020

…n work on themselves children

fix #1281

@yyx990803
Copy link
Member

I took another look at this and I think it is better to just bail stringification for all slot content.

Pro: ensures child components can always expect to work with vdom nodes regardless of depth.

Cons: cannot take advantage of stringification inside slots - which seems to be an ok trade-off since the nodes are still hoisted, and it is quite rare for large pieces of static content to be placed inside slots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default slot returns single static node
2 participants