fix(compiler-core): warn for empty vOn expression + improve performan… #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce of detect cache props fix vuejs#1716
posva
reviewed
Jul 27, 2020
yyx990803
reviewed
Jul 27, 2020
| if (exp && !exp.content.trim()) { | ||
| exp = undefined | ||
| } | ||
| if (!exp && !modifiers.length) { |
There was a problem hiding this comment.
This check should be performed before setting empty exp to undefined because empty v-on with modifiers are allowed, e.g. @click.prevent
yyx990803
reviewed
Jul 27, 2020
| if (__BROWSER__) { | ||
| return false | ||
| } | ||
| if (!context.cacheHandlers) { |
There was a problem hiding this comment.
This check should be performed in all cases because cacheHandlers is not the only mechanism that uses the cache, another example is v-once, and we may add more in the future.
|
See 5fbd1f4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ce of detect cache props
fix #1716