Return a more reasonable type for arrays. #4807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually it caused a type error in my command line, which complained for missing properties: [Symbol.iterator], [Symbol.unscopables].
|
This does break one of the type tests in Take this Playground comparing the two versions I think this issue requires some further investigation, perhaps a bit more information. Anyways, wanted to point out that the type does make a difference. |
|
FYI I reverted this in 6d46b36 since it turns out to be breaking existing type expectations. Could you please provide a reproduction of the original case where your types were failing so we can look for a better fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually it caused a type error in my command line, which complained for missing properties: [Symbol.iterator], [Symbol.unscopables].