Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): ensure fallthrough *Native events are not dropped during props update (fix #5222) #5228

Merged
merged 1 commit into from Jan 21, 2022

Conversation

LinusBorg
Copy link
Member

This PR solves #5222 where a fallthrough event listener from a Vue 2 v-bind.native was removed on a component re-render.

I would need some guidance regarding how to add a test for this.

@LinusBorg LinusBorg added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. feat: v2 compat need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. labels Jan 9, 2022
@LinusBorg LinusBorg linked an issue Jan 9, 2022 that may be closed by this pull request
@oswaldofreitas
Copy link

can't we move it to p1 or p2? 😀
I'm trying to migrate a big project to Vue 3 and this issue is blocking me

Thank you for the PR

@oswaldofreitas
Copy link

oswaldofreitas commented Jan 14, 2022

@yyx990803 We got to migrate to Vue 3 using this amazing compat mode, however this is the last issue for us to fix before pushing forward to production. The more we wait on it the more conflicts we have which is pretty hard to handle since it's a big codebase, so... If you prioritize this relatively simple one I can pay you a coffee 😀

I hope U$ 10 pay a ☕️ in Singapore?

@LinusBorg
Copy link
Member Author

LinusBorg commented Jan 14, 2022

Coffees don't buy a spot in a (non-existant) priority queue, I'm afraid 🙃

Do you have a lot of native event listeners in your codebase? If their occurrences aren't too numerous you should be able to just remove them and make sure the few components you declared them on have their non-native events declared with emits: .

@oswaldofreitas
Copy link

yes, I have some .native listeners, not sure how many, but I'll definitely search all places and go with your suggestion, thanks again, and sorry for the coffee joke, it wasn't my intention to "buy" a position in the queue, but to say how important this fix is for me :)

@LinusBorg
Copy link
Member Author

LinusBorg commented Jan 14, 2022

I understand. We are moving a bit slower right now as the new docs are being polished for publishing, amongst other reasons. We will pick up speed soon. :)

@yyx990803 yyx990803 merged commit 97f6bd9 into main Jan 21, 2022
6 checks passed
@yyx990803 yyx990803 deleted the linusborg/compat-native-listener-update-5222 branch Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: v2 compat 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@click.native works only first time
3 participants