Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(reactivity): modify the type of Instrumentations #6162

Closed
wants to merge 1 commit into from
Closed

types(reactivity): modify the type of Instrumentations #6162

wants to merge 1 commit into from

Conversation

zqran
Copy link
Contributor

@zqran zqran commented Jun 22, 2022 •
edited
Loading

Explicitly specify the type of xxxInstrumentations instead of using the as(type assertion)

@skirtles-code
Copy link
Contributor

This PR looks good to me, but it seems that #8558 made essentially the same changes, and that has been merged into main. Unless I'm missing something, I think this PR can now be closed.

@yyx990803 yyx990803 closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Issue / PR Management
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zqran @skirtles-code @yyx990803