Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-core):Make sure update:modelValue and update:model-value behave the same on slot #6902

Merged
merged 20 commits into from Nov 9, 2022

Conversation

baiwusanyu-c
Copy link
Contributor

close: #6900

@baiwusanyu-c
Copy link
Contributor Author

baiwusanyu-c commented Oct 18, 2022

I didn't make any changes, why does this unit test sometimes fail to run and sometimes pass @yyx990803 😂

image
image

@baiwusanyu-c baiwusanyu-c marked this pull request as draft Oct 18, 2022
@baiwusanyu-c baiwusanyu-c marked this pull request as ready for review Oct 18, 2022
packages/compiler-core/src/transforms/vOn.ts Outdated Show resolved Hide resolved
packages/compiler-core/src/transforms/vOn.ts Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 20d9ca3
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6369cad4d6a6490009be7e66

@baiwusanyu-c baiwusanyu-c requested a review from posva Oct 18, 2022
@baiwusanyu-c baiwusanyu-c requested review from sxzz and posva and removed request for posva and sxzz Oct 19, 2022
@baiwusanyu-c baiwusanyu-c requested a review from posva Oct 19, 2022
posva
posva approved these changes Oct 21, 2022
@baiwusanyu-c baiwusanyu-c changed the title fix(compiler-core):consistent behavior of update:modelValue and update:model-value fix(compiler-core):Make sure update:modelValue and update:model-value behave the same on slot Oct 26, 2022
Co-authored-by: 三咲智子 (Kevin) <sxzz@sxzz.moe>
@yyx990803 yyx990803 merged commit 5bfe438 into vuejs:main Nov 9, 2022
9 checks passed
@baiwusanyu-c baiwusanyu-c deleted the bwsy/fix/modelvalue branch Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behaviour between @update:modelValue and @update:model-value
4 participants