Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-core):Make sure update:modelValue and update:model-value behave the same on slot #6902

Merged
merged 20 commits into from
Nov 9, 2022
Merged

fix(compiler-core):Make sure update:modelValue and update:model-value behave the same on slot #6902

merged 20 commits into from
Nov 9, 2022

Conversation

baiwusanyu-c
Copy link
Member

close: #6900

@baiwusanyu-c
Copy link
Member Author

baiwusanyu-c commented Oct 18, 2022 •
edited
Loading

I didn't make any changes, why does this unit test sometimes fail to run and sometimes pass @yyx990803 😂

image
image

@baiwusanyu-c baiwusanyu-c marked this pull request as draft October 18, 2022 02:58
@baiwusanyu-c baiwusanyu-c marked this pull request as ready for review October 18, 2022 02:58
posva
posva requested changes Oct 18, 2022
View reviewed changes
packages/compiler-core/src/transforms/vOn.ts Outdated Show resolved Hide resolved
packages/compiler-core/src/transforms/vOn.ts Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Oct 18, 2022 •
edited
Loading

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 20d9ca3
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6369cad4d6a6490009be7e66

@baiwusanyu-c baiwusanyu-c requested review from sxzz and posva and removed request for posva and sxzz October 19, 2022 00:55
@baiwusanyu-c baiwusanyu-c changed the title fix(compiler-core):consistent behavior of update:modelValue and update:model-value fix(compiler-core):Make sure update:modelValue and update:model-value behave the same on slot Oct 26, 2022
@baiwusanyu-c @sxzz
Update packages/compiler-core/src/transforms/vOn.ts
c170254 
Co-authored-by: 三咲智子 (Kevin) <sxzz@sxzz.moe>
@yyx990803 yyx990803 merged commit 5bfe438 into vuejs:main Nov 9, 2022
@baiwusanyu-c baiwusanyu-c deleted the bwsy/fix/modelvalue branch November 9, 2022 09:38
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
@baiwusanyu-c
fix(compiler-core/v-on): only apply case preservation on native eleme…
9d4fee3 
…nts (vuejs#6902)

fix vuejs#6900
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
@baiwusanyu-c @zhangzhonghe
fix(compiler-core/v-on): only apply case preservation on native eleme…
e9e0594 
…nts (vuejs#6902)

fix vuejs#6900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz left review comments

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent behaviour between @update:modelValue and @update:model-value
4 participants
@baiwusanyu-c @posva @sxzz @yyx990803