feat(playground): record vue version in url query #7260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
reviewed
Dec 1, 2022
|
I think having always the latest is recommended, I think you would want the version pinned if you changed or pinned the version. Otherwise might be causing issues when posting errors on vue, since the maintainer might not notice the older version. |
|
@pikax Yes, it will use the latest commit by default. |
|
I believe something equivalent to this feature is now available in the latest Playground. It seems to have been introduced in various stages, but it looks like commit 9e529f8 is the point where the feature was completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use sfc playground, the selected vue version will be reset after we refresh the page or share the url.
This change ships the selected vue version in url query, and will parse and use it when sfc playground first load.