Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and support indented pug templates #7723

Closed
wants to merge 2 commits into from
Closed

Test and support indented pug templates #7723

wants to merge 2 commits into from

Conversation

rudolfbyker
Copy link

This was referenced Feb 15, 2023
Closed
Open
@sxzz sxzz added the 🛑 on hold This PR can't be merged until other work is finished label Feb 22, 2023
@texastoland texastoland mentioned this pull request Jul 2, 2023
Closed
@rudolfbyker
Copy link
Author

What does "on hold" mean? Do you need anything else from my side?

@pikax pikax removed the 🛑 on hold This PR can't be merged until other work is finished label Oct 20, 2023
@yyx990803 yyx990803 closed this in 6345197 Dec 1, 2023
@yyx990803
Copy link
Member

Thanks a lot for the PR, the issue is that doing so in compileTemplate ignores the columns change for the source maps, so it has to be done during the parse / source map gen phase. See 6345197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Issue / PR Management
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rudolfbyker @yyx990803 @pikax @sxzz