refactor: replace Object.assign with extend
#8988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alfred-Skyblue
changed the title
() => {} with NOOPObject.assign and () => {}
sxzz
approved these changes
Aug 19, 2023
sxzz
force-pushed
the
replace-function-noop
branch
from
4999323
to
a1d18a3
Compare
Size ReportBundles
Usages
|
sxzz
changed the title
Object.assign and () => {}Object.assign and () => {}
LinusBorg
approved these changes
Oct 21, 2023
sxzz
approved these changes
Oct 22, 2023
yyx990803
requested changes
Nov 30, 2023
Alfred-Skyblue
force-pushed
the
replace-function-noop
branch
from
f805770
to
1b2cd45
Compare
Alfred-Skyblue
force-pushed
the
replace-function-noop
branch
from
1b2cd45
to
24d7fc2
Compare
|
The previous version also had a change involving |
Alfred-Skyblue
changed the title
Object.assign and () => {}Object.assign with extend
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use shared utils to replace
Object.assignand() => {}.