Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(collectionHandlers): key should toRaw in trigger #920

Closed
wants to merge 3 commits into from
Closed

fix(collectionHandlers): key should toRaw in trigger #920

wants to merge 3 commits into from

Conversation

ysj16
Copy link
Contributor

@ysj16 ysj16 commented Apr 4, 2020

to fix #919

@ysj16 ysj16 closed this Apr 4, 2020
@ysj16 ysj16 reopened this Apr 4, 2020
@ysj16
Copy link
Contributor Author

ysj16 commented Apr 4, 2020 •
edited
Loading

A reactive object will toRaw in Map.set, so there will be both origin object and reactive object in map in #919, so I just delete the reactive one. If it's not a good way, you can close this PR at any time.:smile:

@yyx990803
Copy link
Member

Thanks, see 5dcc645

@yyx990803 yyx990803 closed this Apr 4, 2020
@ysj16 ysj16 deleted the fix919 branch April 5, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Effect don't work when use reactive to proxy a Map which has reactive object as member's key.
2 participants
@ysj16 @yyx990803