Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add __VUE_PROD_HYDRATION_MISMATCH_DETAILS__ flag #9550

Merged
merged 2 commits into from
Dec 8, 2023
Merged

feat: add __VUE_PROD_HYDRATION_MISMATCH_DETAILS__ flag #9550

merged 2 commits into from
Dec 8, 2023

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Nov 5, 2023

This PR adds a new compile-time feature flag -- __VUE_PROD_HYDRATION_MISMATCH_DETAILS__ -- the vite plugin will also need an update.

It's needed in vitepress to print hydration mismatch warnings in debug builds (vuejs/vitepress#422). Currently there is no straightforward way to debug those (vitepress can't opt into dev mode during build).

Additional context

Copy link

github-actions bot commented Nov 5, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.5 kB 32.9 kB 29.7 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.3 kB 19.7 kB 17.9 kB
overall 61.3 kB 23.7 kB 21.6 kB

@haoqunjiang haoqunjiang added the ready to merge The PR is ready to be merged. label Nov 7, 2023
@yyx990803 yyx990803 changed the base branch from main to minor December 8, 2023 07:49
@yyx990803 yyx990803 merged commit bc7698d into vuejs:minor Dec 8, 2023
2 checks passed
@yyx990803
Copy link
Member

Note: feature flag added in @vitejs/plugin-vue and @vitejs/plugin-vue-jsx in vitejs/vite-plugin-vue@0fbc4a4

@brc-dd brc-dd deleted the feat/hydration-details-flag branch December 8, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants