chore: explicitly set tsBuildInfoFile in tsconfig.*.json files #409
Conversation
To avoid polluting the root directory with tsconfig.*.tsbuildinfo files. `outDir` in the base config doesn't work because of vuejs/tsconfig#27 (comment) Besides, we need this explicit config in `tsconfig.node.json` anyways, as it doesn't extend from `@vue/tsconfig`. Using `.tmp` instead of `.cache` here to better indicate the purpose.
|
Is it worth adding comments to explain what the lines in tsconfig are doing and why? |
|
I thought the option name and the path were self-explanatory enough? |
That's worth adding to every option in tsconfig files, though. Let's do it in a separate PR. |
| @@ -4,7 +4,8 @@ | |||
| "exclude": ["src/**/__tests__/*"], | |||
| "compilerOptions": { | |||
| "composite": true, | |||
| "noEmit": true, | |||
| "tsBuildInfoFile": "./node_modules/.tmp/tsconfig.app.tsbuildinfo", | |||
|
|
|||
There was a problem hiding this comment.
nit: empty line should be remove? Here and in other configs.
There was a problem hiding this comment.
I was trying to distinguish the emitting-related options from other options… The empty lines would make more sense once we add more detailed explanations in the configs.
|
@sodatea Just wondering, what's the reason for removing |
|
@segevfiner I suppose because TSC project references require emitting declarations, compare my comment here. |
😅 I ran into the same question when reviewing my own code… I should've left more comments in the commit… It's because |
To avoid polluting the root directory with tsconfig.*.tsbuildinfo files.
outDirin the base config doesn't work because of vuejs/tsconfig#27 (comment) Besides, we need this explicit config intsconfig.node.jsonanyways, as it doesn't extend from@vue/tsconfig.Using
.tmpinstead of.cachehere to better indicate the purpose.