chore: explicitly set tsBuildInfoFile in tsconfig.*.json files #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid polluting the root directory with tsconfig.*.tsbuildinfo files. `outDir` in the base config doesn't work because of vuejs/tsconfig#27 (comment) Besides, we need this explicit config in `tsconfig.node.json` anyways, as it doesn't extend from `@vue/tsconfig`. Using `.tmp` instead of `.cache` here to better indicate the purpose.
|
Is it worth adding comments to explain what the lines in tsconfig are doing and why? |
|
I thought the option name and the path were self-explanatory enough? |
That's worth adding to every option in tsconfig files, though. Let's do it in a separate PR. |
cexbrayat
approved these changes
Dec 20, 2023
| @@ -4,7 +4,8 @@ | |||
| "exclude": ["src/**/__tests__/*"], | |||
| "compilerOptions": { | |||
| "composite": true, | |||
| "noEmit": true, | |||
| "tsBuildInfoFile": "./node_modules/.tmp/tsconfig.app.tsbuildinfo", | |||
|
|
|||
There was a problem hiding this comment.
nit: empty line should be remove? Here and in other configs.
There was a problem hiding this comment.
I was trying to distinguish the emitting-related options from other options… The empty lines would make more sense once we add more detailed explanations in the configs.
|
@sodatea Just wondering, what's the reason for removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid polluting the root directory with tsconfig.*.tsbuildinfo files.
outDirin the base config doesn't work because of vuejs/tsconfig#27 (comment) Besides, we need this explicit config intsconfig.node.jsonanyways, as it doesn't extend from@vue/tsconfig.Using
.tmpinstead of.cachehere to better indicate the purpose.