Skip to content

Commit ed84e63

Browse files
authored
fix(ui): destructure slot data binding for DarkToggle component (#160)
1 parent 1e46a51 commit ed84e63

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

packages/client/src/components/common/DockingPanel.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ watch(activeAppRecordId, (id) => {
5252
<VueDarkToggle>
5353
<template #default="{ isDark, toggle }">
5454
<VueButton outlined type="primary" @click="toggle">
55-
<div i-carbon-sun dark:i-carbon-moon translate-y--1px /> {{ isDark.value ? 'Dark' : 'Light' }}
55+
<div i-carbon-sun dark:i-carbon-moon translate-y--1px /> {{ isDark ? 'Dark' : 'Light' }}
5656
</VueButton>
5757
</template>
5858
</VueDarkToggle>

packages/ui/src/components/DarkToggle.vue

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,10 @@ function toggle(event?: MouseEvent) {
7070
)
7171
})
7272
}
73-
const context = {
74-
mode,
75-
isDark,
76-
toggle,
77-
}
7873
</script>
7974

8075
<template>
8176
<span class="$ui-dark-toggle-vtr">
82-
<slot v-bind="context" />
77+
<slot v-bind="{ mode, isDark, toggle }" />
8378
</span>
8479
</template>

packages/ui/storybook/DarkToggle.story.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const dark = computed({
2424
toggle(e)
2525
}"
2626
>
27-
<Icon :class="isDark.value ? 'i-carbon-moon' : 'i-carbon-sun'" />
27+
<Icon :class="isDark ? 'i-carbon-moon' : 'i-carbon-sun'" />
2828
</Button>
2929
</template>
3030
</DarkToggle>
@@ -37,7 +37,7 @@ const dark = computed({
3737
toggle(e)
3838
}"
3939
>
40-
<Icon :class="isDark.value ? 'i-carbon-moon' : 'i-carbon-sun'" />
40+
<Icon :class="isDark ? 'i-carbon-moon' : 'i-carbon-sun'" />
4141
</Button>
4242
</template>
4343
</DarkToggle>

0 commit comments

Comments
 (0)