fix: cannot update states of options-api (#395)

alexzhang1030 · web-flow · commit f138c20f4ea2 · 2024-06-05T17:31:48.000+08:00
diff --git a/package.json b/package.json
@@ -31,6 +31,7 @@
     "stub:applet": "turbo stub --filter=./packages/applet",
     "stub:vite": "turbo stub --filter=./packages/vite",
     "stub:devtools-api": "turbo stub --filter=./packages/devtools-api...",
+    "build:applet": "turbo build --filter=./packages/applet...",
     "build:shared": "turbo build --filter=./packages/shared...",
     "build:core": "turbo build --filter=./packages/core...",
     "build:devtools-kit": "turbo build --filter=./packages/devtools-kit...",
@@ -62,6 +63,7 @@
     "play:multi-app": "turbo dev --filter=./packages/playground/multi-app",
     "play:webpack": "turbo dev --filter=./packages/playground/webpack",
     "play:termui": "turbo dev --filter=./packages/playground/termui",
+    "play:options-api": "turbo dev --filter=./packages/playground/options-api",
     "docs": "pnpm -C docs run docs:dev",
     "docs:build": "pnpm -C docs run docs:build",
     "zip": "tsx ./scripts/extension-zip.ts",
diff --git a/packages/applet/src/components/state/StateFieldViewer.vue b/packages/applet/src/components/state/StateFieldViewer.vue
@@ -137,7 +137,7 @@ function submit() {
     path: normalizedPath.value,
     inspectorId: state.value.inspectorId,
     type: data.stateType!,
-    nodeId,
+    nodeId: nodeId.value,
     state: {
       newKey: null!,
       type: editingType.value,
@@ -164,7 +164,7 @@ function submitDrafting() {
     path: [...normalizedPath.value, draftingNewProp.value.key],
     inspectorId: state.value.inspectorId,
     type: data.stateType!,
-    nodeId,
+    nodeId: nodeId.value,
     state: {
       newKey: draftingNewProp.value.key,
       type: typeof toSubmit(draftingNewProp.value.value),
diff --git a/packages/applet/src/composables/state-editor.ts b/packages/applet/src/composables/state-editor.ts
@@ -1,5 +1,5 @@
 import type { InjectionKey, Ref } from 'vue'
-import { inject, provide, ref } from 'vue'
+import { computed, inject, provide, ref } from 'vue'
 
 interface StateEditorContext {
   nodeId: string
@@ -40,7 +40,7 @@ export function useStateEditor() {
       editing.value = !editing.value
     },
     editingType,
-    nodeId: state.value.nodeId,
+    nodeId: computed(() => state.value.nodeId),
   }
 }
 
diff --git a/packages/devtools-kit/src/core/component/state/editor.ts b/packages/devtools-kit/src/core/component/state/editor.ts
@@ -160,10 +160,13 @@ export async function editComponentState(payload: InspectorStateEditorPayload, s
   let target: Record<string, unknown> | undefined
 
   // TODO: props
-  if (instance.devtoolsRawSetupState && Object.keys(instance.devtoolsRawSetupState).includes(path[0])) {
-    // Setup
+
+  // 1. check if is setup
+  if (instance.devtoolsRawSetupState && Object.keys(instance.devtoolsRawSetupState).includes(path[0]))
     target = instance.devtoolsRawSetupState
-  }
+  // 2. check if is options
+  if (instance.data && Object.keys(instance.data).includes(path[0]))
+    target = instance.data
 
   if (target && targetPath) {
     if (state.type === 'object' && type === 'reactive') {
diff --git a/packages/playground/options-api/index.html b/packages/playground/options-api/index.html
@@ -0,0 +1,18 @@
+<!doctype html>
+<html lang="en">
+  <head>
+    <meta charset="UTF-8" />
+    <link rel="icon" type="image/svg+xml" href="/vite.svg" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <title>Vue DevTools Basic Playground</title>
+  </head>
+  <style>
+    html {
+      color-scheme: dark;
+    }
+  </style>
+  <body>
+    <div id="app"></div>
+    <script type="module" src="/src/main.ts"></script>
+  </body>
+</html>
diff --git a/packages/playground/options-api/package.json b/packages/playground/options-api/package.json
@@ -0,0 +1,16 @@
+{
+  "name": "playground-options-api",
+  "type": "module",
+  "version": "7.2.1",
+  "private": true,
+  "scripts": {
+    "dev": "vite"
+  },
+  "dependencies": {
+    "vue": "^3.4.27"
+  },
+  "devDependencies": {
+    "@vitejs/plugin-vue": "^5.0.4",
+    "vite-plugin-vue-devtools": "workspace:*"
+  }
+}
diff --git a/packages/playground/options-api/public/vite.svg b/packages/playground/options-api/public/vite.svg
@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" class="iconify iconify--logos" width="31.88" height="32" preserveAspectRatio="xMidYMid meet" viewBox="0 0 256 257"><defs><linearGradient id="IconifyId1813088fe1fbc01fb466" x1="-.828%" x2="57.636%" y1="7.652%" y2="78.411%"><stop offset="0%" stop-color="#41D1FF"></stop><stop offset="100%" stop-color="#BD34FE"></stop></linearGradient><linearGradient id="IconifyId1813088fe1fbc01fb467" x1="43.376%" x2="50.316%" y1="2.242%" y2="89.03%"><stop offset="0%" stop-color="#FFEA83"></stop><stop offset="8.333%" stop-color="#FFDD35"></stop><stop offset="100%" stop-color="#FFA800"></stop></linearGradient></defs><path fill="url(#IconifyId1813088fe1fbc01fb466)" d="M255.153 37.938L134.897 252.976c-2.483 4.44-8.862 4.466-11.382.048L.875 37.958c-2.746-4.814 1.371-10.646 6.827-9.67l120.385 21.517a6.537 6.537 0 0 0 2.322-.004l117.867-21.483c5.438-.991 9.574 4.796 6.877 9.62Z"></path><path fill="url(#IconifyId1813088fe1fbc01fb467)" d="M185.432.063L96.44 17.501a3.268 3.268 0 0 0-2.634 3.014l-5.474 92.456a3.268 3.268 0 0 0 3.997 3.378l24.777-5.718c2.318-.535 4.413 1.507 3.936 3.838l-7.361 36.047c-.495 2.426 1.782 4.5 4.151 3.78l15.304-4.649c2.372-.72 4.652 1.36 4.15 3.788l-11.698 56.621c-.732 3.542 3.979 5.473 5.943 2.437l1.313-2.028l72.516-144.72c1.215-2.423-.88-5.186-3.54-4.672l-25.505 4.922c-2.396.462-4.435-1.77-3.759-4.114l16.646-57.705c.677-2.35-1.37-4.583-3.769-4.113Z"></path></svg>
diff --git a/packages/playground/options-api/src/App.vue b/packages/playground/options-api/src/App.vue
@@ -0,0 +1,11 @@
+<script setup lang="ts">
+import Options from './Options.vue'
+import Setup from './Setup.vue'
+</script>
+
+<template>
+  <div>
+    <Options />
+    <Setup />
+  </div>
+</template>
diff --git a/packages/playground/options-api/src/Options.vue b/packages/playground/options-api/src/Options.vue
@@ -0,0 +1,15 @@
+<script lang="ts">
+export default {
+  data() {
+    return {
+      name: 'Vue',
+    }
+  },
+}
+</script>
+
+<template>
+  <div>
+    Options: {{ name }}
+  </div>
+</template>
diff --git a/packages/playground/options-api/src/Setup.vue b/packages/playground/options-api/src/Setup.vue
@@ -0,0 +1,11 @@
+<script setup lang="ts">
+import { ref } from 'vue'
+
+const name = ref('Vue')
+</script>
+
+<template>
+  <div>
+    Setup: {{ name }}
+  </div>
+</template>
diff --git a/packages/playground/options-api/src/main.ts b/packages/playground/options-api/src/main.ts
@@ -0,0 +1,4 @@
+import { createApp } from 'vue'
+import App from './App.vue'
+
+createApp(App).mount('#app')
diff --git a/packages/playground/options-api/src/style.css b/packages/playground/options-api/src/style.css
@@ -0,0 +1,16 @@
+:root {
+  font-family: Inter, Avenir, Helvetica, Arial, sans-serif;
+  font-size: 16px;
+  line-height: 24px;
+  font-weight: 400;
+
+  color-scheme: light dark;
+  color: rgba(255, 255, 255, 0.87);
+  background-color: #242424;
+
+  font-synthesis: none;
+  text-rendering: optimizeLegibility;
+  -webkit-font-smoothing: antialiased;
+  -moz-osx-font-smoothing: grayscale;
+  -webkit-text-size-adjust: 100%;
+}
diff --git a/packages/playground/options-api/uno.config.ts b/packages/playground/options-api/uno.config.ts
@@ -0,0 +1,20 @@
+import {
+  defineConfig,
+  presetAttributify,
+  presetTypography,
+  presetUno,
+  transformerDirectives,
+  transformerVariantGroup,
+} from 'unocss'
+
+export default defineConfig({
+  presets: [
+    presetUno(),
+    presetAttributify(),
+    presetTypography(),
+  ],
+  transformers: [
+    transformerDirectives(),
+    transformerVariantGroup(),
+  ],
+})
diff --git a/packages/playground/options-api/vite.config.ts b/packages/playground/options-api/vite.config.ts
@@ -0,0 +1,16 @@
+import { defineConfig } from 'vite'
+import vue from '@vitejs/plugin-vue'
+import VueDevTools from 'vite-plugin-vue-devtools'
+
+// https://vitejs.dev/config/
+export default defineConfig({
+  plugins: [
+    vue(),
+    VueDevTools({
+      launchEditor: 'code',
+    }),
+  ],
+  server: {
+    port: 3000,
+  },
+})
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`import type { InjectionKey, Ref } from 'vue'`
`2`		`-import { inject, provide, ref } from 'vue'`
	`2`	`+import { computed, inject, provide, ref } from 'vue'`
`3`	`3`
`4`	`4`	`interface StateEditorContext {`
`5`	`5`	`nodeId: string`
`@@ -40,7 +40,7 @@ export function useStateEditor() {`
`40`	`40`	`editing.value = !editing.value`
`41`	`41`	`},`
`42`	`42`	`editingType,`
`43`		`- nodeId: state.value.nodeId,`
	`43`	`+ nodeId: computed(() => state.value.nodeId),`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`