fix: respect LAUNCH_EDITOR env rather than forcing 'code' as default #401
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user's LAUNCH_EDITOR env is being overwritten by the default
launchEditor
option. If nolaunchEditor
option is specified it should default to theLAUNCH_EDITOR
env value. Currently iflaunchEditor
is not specified, the option is set to"code"
and the user's LAUNCH_EDITOR setting is ignored.This change will respect the user's LAUNCH_EDITOR env by default if no
launchEditor
option is specified.This also allows an arbitrary string as a valid
launchEditor
type, which is a valid option forlaunch-editor
and is needed for custom launch scripts or when editors are installed in non-standard locations.This fixes #369