Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct docs #1934

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Correct docs #1934

merged 3 commits into from
Jun 12, 2023

Conversation

TheJaredWilcurt
Copy link
Contributor

Example: https://jsfiddle.net/b4cyeht6

This works the same in Vue 2 and Vue 3.

Example: https://jsfiddle.net/b4cyeht6

This works the same in Vue 2 and Vue 3.
@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit c217715
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/648692af87a3a60008a0221e
😎 Deploy Preview https://deploy-preview-1934--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! You're right, the current wording is incorrect.

I've provided some feedback below on your proposed changes.

@@ -593,7 +593,7 @@ When a prop is declared to allow multiple types, e.g.

```js
defineProps({
disabled: [Boolean, Number]
disabled: [String, Boolean, Number]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why these examples need to change. They seem fine to me as they were.

src/guide/components/props.md Outdated Show resolved Hide resolved
yyx990803 and others added 2 commits June 12, 2023 11:35
Co-authored-by: skirtle <65301168+skirtles-code@users.noreply.github.com>
@yyx990803 yyx990803 merged commit dd41c35 into vuejs:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants