Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: component slots #2780

Merged
merged 2 commits into from
Apr 2, 2024
Merged

fix: component slots #2780

merged 2 commits into from
Apr 2, 2024

Conversation

AloisSeckar
Copy link
Contributor

@AloisSeckar AloisSeckar commented Apr 2, 2024 •
edited
Loading

Description of Problem

  1. New section for "Conditional slots" is missing anchor as other headings have
  2. Links to $slots and v-if are absolute, so they dont work with translations

Proposed Solution

  • add anchor
  • make links relative

Additional Information

@netlify Netlify
Copy link

netlify bot commented Apr 2, 2024 •
edited
Loading

✅ Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit a4893df
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/660c54484615fc0008883117
😎 Deploy Preview https://deploy-preview-2780--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AloisSeckar AloisSeckar changed the title fix: missing anchor in slots fix: component slots Apr 2, 2024
@AloisSeckar AloisSeckar mentioned this pull request Apr 2, 2024
Closed
@brc-dd brc-dd merged commit e7163d4 into vuejs:main Apr 2, 2024
5 checks passed
@AloisSeckar AloisSeckar deleted the anchor branch May 1, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AloisSeckar @brc-dd