-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move component basics section #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NataliaTepluhina
added
content
Issues / PRs related to docs content
enhancement
New feature or request
labels
Jan 22, 2020
znck
reviewed
Jan 23, 2020
Co-Authored-By: Rahul Kadyan <hi@znck.me>
…to move-component-basics
@znck changed back to camelCased names after the issue fix. The only kebab-cased thing is a Could you please give it the last (I hope so!) look? |
znck
reviewed
Jan 28, 2020
Co-Authored-By: Rahul Kadyan <hi@znck.me>
Co-Authored-By: Rahul Kadyan <hi@znck.me>
@znck added an explanation of case-insensitiveness and using kebab-cased names |
znck
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please when reviewing pay attention to v-model part: I was trying to check it thoroughly but it's always better to have more pairs of eyes on it