Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for "JavaScript and TypeScript Nightly" #1629

Merged
merged 2 commits into from
Jul 25, 2022
Merged

feat: support for "JavaScript and TypeScript Nightly" #1629

merged 2 commits into from
Jul 25, 2022

Conversation

tjx666
Copy link
Contributor

@tjx666 tjx666 commented Jul 24, 2022

@johnsoncodehk johnsoncodehk linked an issue Jul 25, 2022 that may be closed by this pull request
@johnsoncodehk johnsoncodehk changed the title wip: support use latest ts version feat support for "JavaScript and TypeScript Nightly" Jul 25, 2022
@johnsoncodehk johnsoncodehk changed the title feat support for "JavaScript and TypeScript Nightly" feat: support for "JavaScript and TypeScript Nightly" Jul 25, 2022
@johnsoncodehk johnsoncodehk merged commit 146c350 into vuejs:master Jul 25, 2022
@@ -158,6 +149,17 @@ function getWorkspaceTsPaths(useDefault = false) {
}

function getVscodeTsPaths() {
const nightly = vscode.extensions.getExtension('ms-vscode.vscode-typescript-next');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that user can only select nightly version when user install ms-vscode.vscode-typescript-next extension. They can't select the builtin typescript version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for consistent with VSCode behavior, because seems VSCode cannot select it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support using nightly TypeScript
2 participants