fix(language-core): type-checking not working with hyphen in slot name with JS #4478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Want to fix #3819.
The related TypeScript issue (microsoft/TypeScript#58908) indicates that this TypeScript behavior might not be fixed in a short time on TypeScriript's side. So this PR means to solve this on Volar's side.
Previously, the virtual code for
was
Now, is should be
The information should be provided by
T1
.However, because I am new to Volar, I can't figure out how to make this work correctly. The generated virtual code is OK now, but the hint for
#a-b
still doesn't show (Ifa-b
is not a defined slot). This is quite strange.