Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-core): infer define model type from options type #4545

Merged
merged 3 commits into from
Jul 19, 2024
Merged

fix(language-core): infer define model type from options type #4545

merged 3 commits into from
Jul 19, 2024

Conversation

davidmatter
Copy link
Collaborator

@davidmatter davidmatter commented Jul 8, 2024 •
edited
Loading

If T in defineModel<T> is not defined, try to infer from user's code.

@davidmatter davidmatter linked an issue Jul 8, 2024 that may be closed by this pull request
Typescript v-model defined types missing #4512
Closed
@davidmatter davidmatter requested a review from so1ve July 8, 2024 11:05
@johnsoncodehk
Copy link
Member

LGTM, thanks for your investigation!

@johnsoncodehk johnsoncodehk merged commit 7935b36 into vuejs:master Jul 19, 2024
3 checks passed
This was referenced Aug 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsoncodehk johnsoncodehk Awaiting requested review from johnsoncodehk johnsoncodehk is a code owner

@so1ve so1ve Awaiting requested review from so1ve so1ve is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript v-model defined types missing
3 participants
@davidmatter @johnsoncodehk @so1ve