fix(types): allow components defined via defineComponent #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
|
@posva I have no better idea 🤔 We also struggled in VTU to get it right (and we might still have some issues). If @yyx990803 agrees, I think it would be great if Vue exposed a directly usable type 👍 The shim and libs would be simplified |
pikax
reviewed
Aug 14, 2020
yyx990803
added a commit
to vuejs/core
that referenced
this pull request
Aug 19, 2020
returned from `defineComponent` ref: vuejs/router#421 also close #1880 Previous `Component` type is now exported as `ConcreteComponent`. This introduces a minor breaking change when calling `h(comp, { ... })` will now fail if `comp` is a of generic `Component` type, since it does not specify what props it expects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #420
Close #361
I'm not sure about this one, specially the one way I extract PublicAPIComponent because If I don't add he cast to
Component,h()yields a type error. @yyx990803 do you think it makes sense to exposePublicAPIComponentMaybe you have a better idea @pikax, @cexbrayat ?