Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(warn): throws if history is missing #844

Merged
merged 3 commits into from
Mar 24, 2021
Merged

feat(warn): throws if history is missing #844

merged 3 commits into from
Mar 24, 2021

Conversation

cool-little-fish
Copy link
Contributor

Fix #843

@posva posva changed the title fix(warn): add warning when missing histroy option feat(warn): add warning when missing histroy option Mar 24, 2021
@posva posva changed the title feat(warn): add warning when missing histroy option feat(warn): throws if history is missing Mar 24, 2021
posva
posva requested changes Mar 24, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/router.ts Outdated Show resolved Hide resolved
__tests__/router.spec.ts Outdated Show resolved Hide resolved
@posva posva merged commit dd8bf6c into vuejs:master Mar 24, 2021
@hay
Copy link

hay commented Mar 24, 2021

Tested and works as expected. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not setting history option in initial config leads to confusing error
3 participants
@cool-little-fish @hay @posva