Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change provides to provides #27

Closed
lmiller1990 opened this issue Mar 28, 2020 · 3 comments · Fixed by #32
Closed

Change provides to provides #27

lmiller1990 opened this issue Mar 28, 2020 · 3 comments · Fixed by #32
Assignees
Labels

Comments

@lmiller1990
Copy link
Member

functionality exists but naming is wrong (provides, should be provide)

@lmiller1990 lmiller1990 mentioned this issue Mar 28, 2020
18 tasks
@dobromir-hristov
Copy link
Contributor

dobromir-hristov commented Mar 28, 2020

Should we move provide to the global property?

@lmiller1990
Copy link
Member Author

Hm - I guess that does make sense, it feels a bit more intuitive to me to have it in the regular mounting options to me.

We could actually support it in both (and do the same thing). Happy to go either way.

@lmiller1990 lmiller1990 self-assigned this Mar 29, 2020
@lmiller1990
Copy link
Member Author

I thought about it a bit, I think provide goes in global. all the other things (data, props) are really on the component, but provide comes from above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants