Add isVisible and stub transition/transition-group by default #212
Conversation
lmiller1990
changed the title
| } | ||
| } | ||
|
|
||
| it('returns false when element hidden via v-show', () => { |
There was a problem hiding this comment.
suggestion: WDYT of adding one more pair of tests returns false when ancestor is hidden via v-show to capture our intent - we're detecting visibility not only on entire element itself
| element.nodeName !== '#comment' && | ||
| isStyleVisible(element) && | ||
| isAttributeVisible(element) && | ||
| (!element.parentElement || isElementVisible(element.parentElement)) |
There was a problem hiding this comment.
I guess this was battle-tested in VTU 1, but just in case here is how jQuery tests the visibility https://github.com/jquery/jquery/blob/d0ce00cdfa680f1f0c38460bc51ea14079ae8b07/src/css/hiddenVisibleSelectors.js (we implement the same logic in an Angular testing library).
There was a problem hiding this comment.
I just coped this from another library (dom-testing-library, or something? same as V1).
There is even more robust visible checks out there; since the primary use case is v-show, which does this via display: none, I think this should cover the main use cases. We could make it more robust if someone has a problem. Surprisingly how had a true visibility selector can be to implement...
There was a problem hiding this comment.
resolves #210
isVisibleback. We decided to un-deprecate it in V1, porting it to V2.v-show.transition: falseandtransition-group: falsetoglobal.stubs.config.global.stubs = { transition: false }. This is useful for libraries like cypress-vue who do not stub things, since they are not constrained by things likenextTicklike when testing in jsdom with jest.